Skip to content

feat(mail): add sender list skill docs#1316

Open
xulong3370 wants to merge 1 commit into
larksuite:mainfrom
xulong3370:feat/b4e2b91
Open

feat(mail): add sender list skill docs#1316
xulong3370 wants to merge 1 commit into
larksuite:mainfrom
xulong3370:feat/b4e2b91

Conversation

@xulong3370

@xulong3370 xulong3370 commented Jun 7, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Generated by the harness-coding skill.

  • Branch: feat/b4e2b91
  • Target: main

Commits on branch (ahead of main)

Commit Subject
85df4dc feat(mail): add sender list skill docs

This resume run

ID Title Status Commit
S6 Regenerate meta_data.json + lark-mail skill docs for new allow_block_senders commands passed 85df4dc
S9 Synthesize transport contract for larksuite/cli passed e1bb9db

Source specs

  • tech-design.md

This PR was created autonomously. Quality gates were enforced by the repo's own pre-commit hooks.

Summary by CodeRabbit

  • Documentation
    • Added documentation for user-level allow/block sender lists to help users manage trusted and blocked senders.
    • Included guidance on managing these lists with batch operations and viewing capabilities.
    • Added permission scope information for sender management features.

@xulong3370
feat(mail): add sender list skill docs
85df4dc 
Regenerate the mail skill surface for user allow and blocked sender APIs.

Document the user-level allow/block sender concept in the mail skill template.

Use requiredScopes for list permission rows when the generator-selected scope is broader than the API requirement.
@CLAassistant

CLAassistant commented Jun 7, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Jun 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1092d76c-d407-46b7-b977-715f63db9c85

📥 Commits

Reviewing files that changed from the base of the PR and between e1bb9db and 85df4dc.

📒 Files selected for processing (2)
  • skill-template/domains/mail.md
  • skills/lark-mail/SKILL.md
📝 Walkthrough

Walkthrough

This PR introduces documentation for a new user-level sender allowlist and blocklist feature in the Lark mail API. Changes span domain reference templates, API resource specifications, and permission scope mappings across two documentation files.

Changes

Sender Allow/Block List Feature Docs

Layer / File(s) Summary
Core Concept Introduction
skill-template/domains/mail.md, skills/lark-mail/SKILL.md		 Core concept entries added to both the domain reference template and main skill documentation, describing user-level sender allowlists and blocklists as managed by user_mailbox.allow_senders and user_mailbox.blocked_senders resources, listing supported operations (list, batch add/remove), and documenting usage conventions like passing user_mailbox_id="me" and inspecting schema fields.
API Resources and Methods
skills/lark-mail/SKILL.md		 Specifies user_mailbox.allow_senders and user_mailbox.blocked_senders resources with batch_create, batch_remove, and list operations. Documents address/domain format rules, per-call and total sender limits, mutual exclusivity between allow and block lists, and pagination behavior.
Permission Scope Mappings
skills/lark-mail/SKILL.md		 Adds permission scope table entries mapping batch create/remove operations to mail:user_mailbox.message:modify and list operations to mail:user_mailbox.message:readonly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

domain/mail, size/M

Suggested reviewers

  • chanthuang

Poem

🐰 A inbox so neat, with senders held dear,
Blocklists and allowlists, crystal and clear!
Docs spell it all out—batch methods that flow,
Permissions and schemas—now users will know! 📬✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is missing critical sections from the template: Summary, Changes list, Test Plan with verification checkboxes, and Related Issues are not provided in the expected format. Add a proper Summary section explaining motivation, a structured Changes list, a Test Plan with verification checkboxes, and a Related Issues section following the repository template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat(mail): add sender list skill docs' clearly and concisely summarizes the main change: adding documentation for sender list functionality in the mail skill.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added domain/mail PR touches the mail domain size/M Single-domain feat or fix with limited business impact labels Jun 7, 2026
@xulong3370

xulong3370 commented Jun 8, 2026

Copy link
Copy Markdown
Author

🤖 AI Review | CR 汇总 | 可合入（未发现问题）

增量审查：本 PR 暂无既有评论；本次只发现后端和 registry 侧问题，CLI 文档同步本身未发现新增问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

domain/mail PR touches the mail domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xulong3370 @CLAassistant